Correctly interpret options.clobber. #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--no-clobber results in options.clobber being false. Fixes dthree#97.
|
@tituomin it looks like this breaks a Travis test case. Would you be able to take a look? Default behavior should be |
|
This fixes the problem. However, when testing manually using cash as a command line interpreter, I noticed another bug: it seems that vorpal is a bit confused with the "-n --no-clobber" option specification:
So it seems vorpal equates "n" with "clobber", not with "no-clobber". Unfortunately I don't have time to go into this right now. (Should create an issue in the vorpal repo). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--no-clobber results in options.clobber being
false.
Fixes #97.